fixes: #11758 with a workaround with https proxy-agent

[tristanrobert]

Summary

Fixes 400 Bad request in credentials with https transport (https://mattermost... or https://grist...) when n8n is self hosted or launched in dev (pnpm start) behind a corporate proxy with http (http://proxy...), see #11758

Related Linear tickets, Github issues, and Community forum posts

fixes #11758

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

@tristanrobert have you seen #11004 already? This looks similar and may also have the same risks.

[netroy]

Just FYI: This has been attempted a couple times before, including #11004.
And every time it has broken some of the custom stuff we do with agents (see the comment in the other PR).
What we need to do is create our own custom Agent type that encapsulates all our custom code and proxy support.

The current code is a mess, lacks test coverage, and if we merge this we risk creating regressions that are likely not worth the value proxy support brings.

We definitely want to do this, and will get to it when we can.

[Joffcom]

Hey @tristanrobert,

Thanks for the PR, We have created "GHC-450" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

[tristanrobert]

@tristanrobert have you seen #11004 already? This looks similar and may also have the same risks.

I have just wrapped the https agent (same axiosconfig except I deactivate direct proxy) with a proxy-agent.

[tristanrobert]

Just FYI: This has been attempted a couple times before, including #11004. And every time it has broken some of the custom stuff we do with agents (see the comment in the other PR). What we need to do is create our own custom Agent type that encapsulates all our custom code and proxy support.

The current code is a mess, lacks test coverage, and if we merge this we risk creating regressions that are likely not worth the value proxy support brings.

We definitely want to do this, and will get to it when we can.

Axios does not run well with proxy config, the easier workaround would be to deactivate any direct proxy config in axios and pass a wrapped https agent with proxy-agent. I agree code would need refactoring. When I fixed Mattemost credentials, I have seen that Grist credentials does not use the same function to build the axiosconfig, the proxy connection config. It uses this temporary function:

n8n/packages/core/src/NodeExecuteFunctions.ts

Line 305 in bd924c7

export async function parseRequestObject(requestObject: IRequestOptions) {

when Mattermost uses this function:

n8n/packages/core/src/NodeExecuteFunctions.ts

Line 907 in bd924c7

function convertN8nRequestToAxios(n8nRequest: IHttpRequestOptions): AxiosRequestConfig {

I agree that it should be refactored and I think all the proxy conf should be deleted and let proxy-agent do the job.