fix(Notion Node): Extract page url #11643
Open
+149
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
elsmr
previously approved these changes
Nov 8, 2024
| pageId = page.value.split('p=')[1].split('&')[0]; | ||
| } else { | ||
| // e.g https://www.notion.so/page_name-xxxxx | ||
| pageId = page.value.match(databasePageUrlValidationRegexp)?.[1] || ''; |
There was a problem hiding this comment.
this how it works in rlc when extracting value, taking match from regex
elsmr
reviewed
Nov 8, 2024
Co-authored-by: Elias Meire <[email protected]>
…notion-node-database-page-param-cant-parse-pip-links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for extracting page url from urls of type
https://www.notion.so/xxxxx?v=xxxxx&p=xxxxx&pm=sRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1419/notion-node-database-page-param-cant-parse-pip-links