Skip to content

Commit

Permalink
fix: Fix flaky remote options loading test (no-changelog) (#7433)
Browse files Browse the repository at this point in the history
Background: Looks like remote options loading needs a bit of time to
catch up when dependent parameter changes so when using cypress `type`
method without delay it fails to update the values properly. Since this
does not represent actual component behavior when real user interact
with it we added a delay to automated typing.

This PR increases typing delay, giving the component more time to
breathe when run in CI
- [Latest e2e
run](https://github.com/n8n-io/n8n/actions/runs/6506583716)
- [Video of this specific
test](https://cloud.cypress.io/projects/5hbsdn/runs/aa4f1a7d-b95f-4c8a-acd6-33061d290c7b/test-results/21a1abdf-1e1c-43bf-a640-8cc39b11cc46/video)
  • Loading branch information
MiloradFilipovic authored and krynble committed Oct 13, 2023
1 parent ca0d4d2 commit c079fd6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cypress/e2e/5-ndv.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ describe('NDV', () => {
ndv.getters.parameterInput('remoteOptions').click();
getVisibleSelect().find('.el-select-dropdown__item').should('have.length', 3);

ndv.actions.setInvalidExpression({ fieldName: 'fieldId', delay: 100 });
ndv.actions.setInvalidExpression({ fieldName: 'fieldId', delay: 200 });

ndv.getters.container().click(); // remove focus from input, hide expression preview

Expand Down

0 comments on commit c079fd6

Please sign in to comment.