* rename variables whose type inherits from BaseCrawlFacade from `c…
#50
n0099Annotations
9 errors
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/MetadataConsumer.cs#L379
Type 'DateTimeAndOffset' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
build (imagePipeline):
c#/imagePipeline/src/Consumer/MetadataConsumer.cs#L379
Type 'DateTimeAndOffset' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
build (imagePipeline)
Process completed with exit code 1.
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/BaseSaver.cs#L6
'SaverWithRevision<TBaseRevision>' implements 'IFieldChangeIgnorance' so 'IFieldChangeIgnorance' can be removed from the inheritance list. (https://rules.sonarsource.com/csharp/RSPEC-1939)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/Post/BasePostSaver.cs#L24
Method 'OnPostSaveEvent' raises event 'PostSaveEvent', so it should be protected and virtual (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1225.md)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/BaseSaver.cs#L6
'SaverWithRevision<TBaseRevision>' implements 'IFieldChangeIgnorance' so 'IFieldChangeIgnorance' can be removed from the inheritance list. (https://rules.sonarsource.com/csharp/RSPEC-1939)
|
|
build (crawler):
c#/crawler/src/Tieba/Crawl/Saver/Post/BasePostSaver.cs#L24
Method 'OnPostSaveEvent' raises event 'PostSaveEvent', so it should be protected and virtual (https://github.com/dennisdoomen/CSharpGuidelines/blob/5.6.0/_rules/1225.md)
|
|
build (crawler)
Process completed with exit code 1.
|
|
ReSharper
The process '/home/runner/.dotnet/tools/jb' failed with exit code 1
|