Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message about rubocop-rspec_rails #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arvida
Copy link

@arvida arvida commented Dec 10, 2024

Was getting this message, it looks like we need require the rspec rails cops seperatly:

Error: RSpec/Railscops have been extracted to therubocop-rspec_rails gem. (obsolete configuration found in .rubocop-https---raw-githubusercontent-com-mynewsdesk-mnd-rubocop-master--rubocop-yml, please update it)

Was getting this message, it looks like we need require the rspec rails
cops seperatly:

Error: `RSpec/Rails` cops have been extracted to the `rubocop-rspec_rails` gem.
(obsolete configuration found in .rubocop-https---raw-githubusercontent-com-mynewsdesk-mnd-rubocop-master--rubocop-yml, please update it)
@arvida arvida requested a review from dbackeus December 10, 2024 07:59
@dbackeus
Copy link
Contributor

This repo is a bit complicated to deal with since it depends on certain versions of Rubocop running in our CI environment.

When we change the configuration we also need to change the versions used on CI, which is defined at https://github.com/reclaim-the-stack/rubocop-action/blob/master/action.yml#L9

It might make sense to include a reference to these versions in the README for this repo to understand what's going on.

@antonjarl
Copy link

Jag har inte tänkt på det tidigare, men nu såg jag uppdateringen på mailen. Det kanske är dags att ta bort min access till MND @dbackeus, är ju ändå 4-5 år sen jag slutade.

Annars kommer det snart en "git push -f" från design 😀

@dbackeus
Copy link
Contributor

@antonjarl det här är ett publikt repo så kräver ingen speciell access för att följa. Du kanske har någon notification setting aktivt för det sedan tidigare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants