Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

72 pictures schema #80

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

72 pictures schema #80

wants to merge 5 commits into from

Conversation

drenzetti
Copy link

No description provided.

GendoIkari
GendoIkari reviewed Jun 20, 2017
View reviewed changes
models.py Outdated
@classmethod
def get_schema(cls):
return PictureSchema()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questo OrderItem che ha come schema PictureSchema non mi sembra proprio corretto. Copy-paste andato male?

GendoIkari
GendoIkari reviewed Jun 20, 2017
View reviewed changes
schemas.py Outdated
class PictureSchema(Schema):
uuid = fields.UUID(required=True, dump_only=True)
title = fields.Str(required=True, validate=check_empty_str, dump_only=True)
extension = fields.Str(required=True, validate=check_empty_str, dump_only=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nella ItemPictureResource stiamo prendendo in input title e extension, quindi direi che questi dump_only non ci vogliono.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GendoIkari GendoIkari GendoIkari left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drenzetti @GendoIkari @FV89