cmd/shfmt: Add support for minify and simplify via EditorConfig #1062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never used
go
before, so I this is a naive, but working approach to supportsimplify
andminify
in editorconfig files. I have not looked at adding tests yet, but will add tests if this code change approach is agreeable.Manual testing below.
Adding, for e.g.
-s
or-mn
to theshfmt
call leads to consistent results (i.e. if-s
is on, then for theopts=
,opts="simplify=true"
, we get the second result above, but theopts="minify=true"
option stays consistent withminify
respected).Closes #819.