Corrected version number, super battery address, and shift mode value

[FoxtrotFaux]

Here are the fixes I mentioned in #198 in the main repo.

[mutchiko]

i kept the balanced shift mode as is because C0 value is usually meant for advanced mode on some models.

C1 might stay the same between silent and balanced, but fan mode will change, thats probably how bios reacts to changing shift mode.

to test that, please install mcc as mentioned in BeardOverflow#198 (comment) and report back with your results

[FoxtrotFaux]

Yes, all features are tested working in MControlCenter. Both your fork, and the AUR package.

Tested fan curves, super battery, cooler boost, and all 4 shift modes. Silent shift mode correctly sets the fan mode to silent, and super battery shift mode enables super battery in the sysfs. I do think it would be nice if the fan mode and cooler boost could be rolled into one file in sysfs, but I understand that this is probably unnecessary and inconvenient/incompatible for other hardware.

[mutchiko]

@FoxtrotFaux good to hear, we need a little bit more testing, since you are checking sysfs files from msi-ec, could you check the output of cat /sys/devices/platform/msi-ec/shift_mode in your terminal and compare it to each shift mode you set in MCC? please use my fork (reduced ec calls) to make sure we aren't getting played by ec_sys module

[mutchiko]

it would be nice if the fan mode and cooler boost could be rolled into one file in sysfs

the driver tries to replicate how things are handled in both firmware and official msi apps, these are different features that need to be handled separately.

[FoxtrotFaux]

Ah, good thing you made me test it again. MControlCenter does not work from a clean boot because the shift mode state is C0 which reads as "Unknown (192)" in the sysfs. All options in the main tab are greyed out, but other tabs like battery, fan control, and keyboard brightness do still work fine.

I noticed a bug in fan control as well. Turning off advanced fan control does not reset the fan profile to auto. The previously set custom profile stays in place.

[FoxtrotFaux]

When I uninstall msi-ec and reinstall with balanced set to C0 in order to change shift mode in MControlCenter, then reinstall with balanced set to C1, all modes work as expected. I ran CPUMark in Windows multiple times to compare performance in these modes, and it seems that C0 is equivalent to if not slightly better than extreme (C4).

Silent - 12496
Balanced - 19329
Balanced - 20245
Extreme - 23151
Extreme - 24162
Extreme - 24575
C0 - 24552
C0 - 24603
C0 - 24973

[mutchiko]

you did a good job by testing performance for each shift mode, this is great but not practical.

on ryzen CPUs, changing shift mode changes some cpu power parameters

you need to find the something similar but for intel CPUs on windows
i suggest trying Universal x86 Tuning Utility or Intel Extreme Tuning Utility
when you change shift modes, you should see some parameters change in these utilities, start testing on windows, and note how each value (C0/C1/C4...) have different effects on the cpu tuning