Check if MuseSampler module is added before creating MuseSounds menu items #25786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Dec 23, 2024
…items If the MuseSampler module is not added, then its actions are also not added, so trying to call `makeMenuItem` for a MuseSounds action returns nullptr. And nullptrs in menu items lists cause crashes later on.
cbjeukendrup
force-pushed
the
appmenumodel_musesampler_actions_crash
branch
from
3be6705 to
93c7c6d
Compare
|
(tested on macOS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the MuseSampler module is not added, then its actions are also not added, so trying to call
makeMenuItemfor a MuseSounds action returns nullptr. And nullptrs in menu items lists cause crashes later on.Related to #25662.
Suggestions for a nicer fix are welcome...