Fix MSVC and macOS (Clang) compiler warnings #25723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Dec 4, 2024
•
Jojo-Schmitz
commented
- reg.: declaration of 'xxx' hides previous local declaration (C4456)
- reg.: conversion from 'size_t' to 'int', possible loss of data (C4267)
- reg.: overrides a member function but is not marked 'override' [-Winconsistent-missing-override] (generates a lot of noise in the mac builds)
- reg.: variable set but not used [-Wunused-but-set-variable]
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
4 times, most recently
from
bba09f0 to
8b74bb3
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
3 times, most recently
from
7314433 to
06eb39e
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
4 times, most recently
from
40446c6 to
14aedd4
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
14aedd4 to
062f267
Compare
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
3 times, most recently
from
e9d006a to
6d81810
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
6 times, most recently
from
ed3c490 to
d0bc6e1
Compare
8 tasks
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
3 times, most recently
from
782f446 to
e5dedca
Compare
Jojo-Schmitz
commented
Jan 17, 2025
Jojo-Schmitz
changed the title
mathesoncalum
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Thanks for this @Jojo-Schmitz (and sorry for the delay). I've left some feedback points.
src/importexport/guitarpro/internal/guitarbendimport/benddataprocessor.cpp
Outdated
Show resolved
Hide resolved
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
e5dedca to
ae1a208
Compare
reg.: declaration of 'xxx' hides previous local declaration (C4456)
reg.: conversion from 'size_t' to 'int', possible loss of data (C4267)
reg.: overrides a member function but is not marked 'override' [-Winconsistent-missing-override] (Also fixed in musescore#26100)
reg.: variable set but not used [-Wunused-but-set-variable]
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
ae1a208 to
7dc39c4
Compare
mathesoncalum
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.