-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuning temperaments plugin #25680
base: master
Are you sure you want to change the base?
Tuning temperaments plugin #25680
Conversation
modal temperaments, tuning, and modal tuning are merged into 1 plugin. Temperaments are organized by tab (western/middle eastern temperaments). Added currentTab data to history for proper "undo/redo" function. updated ui with MU components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments below. Also, it would be great if you could make sure that the file is properly formatted:
- make sure the indenting is correct (tip: open the file in Qt Creator, press Ctrl+A and then Ctrl+I to auto-indent it; or Cmd+A, Cmd+I on Mac)
- Make sure there are empty lines wherever they improve readability, but have never more than one empty line in a row
- Make sure there is always a space between the component name and the
{
These things will make it easier to read and review the code. Thanks in advance!
…tCurrentTemperament, checkCurrentTemperament and lookUpTemperament functons accordingly.
f7dde50
to
cd0ed7d
Compare
I'm working on fixing the save/load function. How can I set the source property of FileIO compnent to the relative path of the plugin without setting it explicitly? I tried window.filePath and Qt.resolvedUrl. are these not working on 4.4? I think the undo/redo actions are superflous and not useful at all (why would you need to undo selecting an item). I wonder if it is ok to remove them from the code comlpetely? It woulld make the code much cleaner. |
ok, nevermind the the first question. Qt.resolvedUrl.toString().replace("file:///", ""); wroked. |
…ow be added/removed dynamically by user.
The "annotation" option was not working
There are currently 3 tuning/temperaments plugins (tuning, modal tuning, and modal temperaments). They are the same plugin with different lists of temperaments.
I took the liberty to merge them into a single plugin (i hope that is fine). The temperamentes are separated by tab for western and middle eastern temperaments .
The Ui was updated with MU components as shown below.
Limitation: The save and load functions need yet to be fixed.