Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning temperaments plugin #25680

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ash-86
Copy link

@Ash-86 Ash-86 commented Nov 28, 2024

The "annotation" option was not working
There are currently 3 tuning/temperaments plugins (tuning, modal tuning, and modal temperaments). They are the same plugin with different lists of temperaments.
I took the liberty to merge them into a single plugin (i hope that is fine). The temperamentes are separated by tab for western and middle eastern temperaments .
The Ui was updated with MU components as shown below.
Limitation: The save and load functions need yet to be fixed.

image

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

modal temperaments, tuning, and modal tuning are merged into 1 plugin. Temperaments are organized by tab (western/middle eastern temperaments).  Added currentTab data to history for proper "undo/redo" function.
updated ui with MU components.
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments below. Also, it would be great if you could make sure that the file is properly formatted:

  • make sure the indenting is correct (tip: open the file in Qt Creator, press Ctrl+A and then Ctrl+I to auto-indent it; or Cmd+A, Cmd+I on Mac)
  • Make sure there are empty lines wherever they improve readability, but have never more than one empty line in a row
  • Make sure there is always a space between the component name and the {

These things will make it easier to read and review the code. Thanks in advance!

share/plugins/tuning/tuning.qml Outdated Show resolved Hide resolved
share/plugins/tuning/tuning.qml Outdated Show resolved Hide resolved
share/plugins/tuning/tuning.qml Outdated Show resolved Hide resolved
…tCurrentTemperament, checkCurrentTemperament and lookUpTemperament functons accordingly.
@Ash-86 Ash-86 force-pushed the Tuning-temperaments-plugin branch from f7dde50 to cd0ed7d Compare December 4, 2024 21:41
@Ash-86
Copy link
Author

Ash-86 commented Dec 5, 2024

I'm working on fixing the save/load function. How can I set the source property of FileIO compnent to the relative path of the plugin without setting it explicitly? I tried window.filePath and Qt.resolvedUrl. are these not working on 4.4?

I think the undo/redo actions are superflous and not useful at all (why would you need to undo selecting an item). I wonder if it is ok to remove them from the code comlpetely? It woulld make the code much cleaner.

@Ash-86
Copy link
Author

Ash-86 commented Dec 6, 2024

ok, nevermind the the first question. Qt.resolvedUrl.toString().replace("file:///", ""); wroked.

@Ash-86 Ash-86 requested a review from cbjeukendrup December 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants