-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI to lint the codebase #78
Conversation
I have read the CLA Document and I hereby sign the CLA |
@zicklag if you agree with this PR, I will look for a fix for the ESLint issue. Do you have any suggestions on how to fix the issue? |
Yeah, I'm interested in this. I did a quick search and it looks like the issue we're running into is the same as this vuejs/eslint-config-typescript#52. I'm not exactly sure what the fix is, but we may have to either ignore that lint just for CI, or install typescript in CI before running the lint or something. |
This tool is useful for keeping the formatting style consistent.
98cd6bb
to
e5eba3a
Compare
Too many errors to fix at the moment.
@zicklag , I believe this is ready to merge. There is a new typo in the latest commits. I've temporarily disabled ESLint due to the many errors that need fixing. With the release of ESLint 9, we might want to try it to see if it improves our experience. |
Hi, there.
I've found some inconsistencies in the code. So, perhaps this PR will solve the issue.
This PR adds:
The mentioned tools are also included inside the
justfile
. So, one is able to check locally just usingjust fmt
orjust fmt-check
.The repo had
prettier
andeslint
already, but it seems they were not used in previous commits. So, I have added both to CI and the just recipe too.I use
ci:
as the commit prefix here. If these commits should belong under a different category, I'd be happy to change it.One last step is fixing the error that comes from
eslint
: