Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildenv/1.3.x: merge Windows directories in a single one #81

Merged

Conversation

davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Sep 14, 2018

There's no need for multiple different directories, as the only thing that changes between a build type and another are the parameters passed to setup.cmd.

@davidebeatrici davidebeatrici requested review from mkrautz, Kissaki, a user and hacst September 14, 2018 20:34
There's no need for multiple different directories, as the only thing that changes between a build type and another are the parameters passed to setup.cmd.
@mkrautz
Copy link
Contributor

mkrautz commented Sep 15, 2018

I obviously prefer the directory approach, such that each target has its own directory, and the uniform way to create a buildenv is to just run setup.cmd.

@davidebeatrici
Copy link
Member Author

The problem is that if we change a dependency build script for a single target, we have to do it in the win32-static directory anyway.

@mkrautz
Copy link
Contributor

mkrautz commented Sep 23, 2018

I did it this way, mostly to have clear documentation.

However, I can see wanting this, but I don't really see it as a big priority?... I don't see what's too wrong with the old approach?

@davidebeatrici
Copy link
Member Author

#80 is currently not suitable to build Mumble for Windows XP, because Qt doesn't support it anymore.

As we discussed, I would like to keep Qt 5.6 for x86 and update to Qt 5.9 for x64, meaning that win32-static and win64-static have to use different build scripts.

We could keep the directories separated and provide the two build scripts in win32-static, but I think that it would cause confusion.

@davidebeatrici davidebeatrici merged commit 8c4ba93 into mumble-voip:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants