buildenv/1.3.x/win32-static: add support for MSVC 2017 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
Why is it WIP? @davidebeatrici? Please remedy and submit if OK. |
mkrautz
approved these changes
Sep 30, 2018
It requires #80. |
davidebeatrici
changed the title
|
@davidebeatrici Let's land it and keep the default VSVER to 14.0? Then after landing the dep update, we can bump this? |
davidebeatrici
changed the title
davidebeatrici
force-pushed
the
msvc2017
branch
from
c47615b to
b560078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.