Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildenv/1.3.x/centos-ermine: add intltool to fix build on some distros (such as Ubuntu 17.10). #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkrautz
Copy link
Contributor

@mkrautz mkrautz commented Mar 25, 2018

No description provided.

@Kissaki
Copy link
Member

Kissaki commented Mar 25, 2018

So this is a new tool we didn't use before?
What is it used for?

Maybe a short description of what it is and what it is used for would be useful? In the commit message, maybe in the build script head?

Project page says its about translation strings, but I can't quite make out what it does for us from the build script?

Did we use it as part of sth else but have to patch it so we now pull it as an explicit dependency to do so?

@mkrautz
Copy link
Contributor Author

mkrautz commented Mar 25, 2018

The problem is that the intltool package in Ubuntu 17.10 doesn't have the patch (that we apply in here) applied to it.

Where we normally use the buildenv, on our old CentOS builder, it isn't a problem.

So this is merely a fix for being able to run the build on newer machines.

I'll update things to be more descriptive.

@davidebeatrici davidebeatrici force-pushed the master branch 7 times, most recently from ff585d4 to 4b87926 Compare April 28, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants