Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #1054

Merged
merged 19 commits into from
Nov 8, 2023
Merged

Development #1054

merged 19 commits into from
Nov 8, 2023

Conversation

danielailie
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (b127a6e) 42.75% compared to head (ca70765) 42.88%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   42.75%   42.88%   +0.12%     
==========================================
  Files         395      395              
  Lines        8232     8281      +49     
  Branches      949      952       +3     
==========================================
+ Hits         3520     3551      +31     
- Misses       3813     3828      +15     
- Partials      899      902       +3     
Flag Coverage Δ
unittests 42.88% <52.77%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/modules/nft-traits/nft-traits.elastic.queries.ts 37.93% <100.00%> (+2.21%) ⬆️
src/utils/constants/index.ts 100.00% <100.00%> (ø)
src/modules/assets/assets-getter.service.ts 16.99% <50.00%> (+0.54%) ⬆️
...equests/WhitelistCollectionOnMarketplaceRequest.ts 66.66% <66.66%> (ø)
...ules/collection-stats/collections-stats.service.ts 84.84% <33.33%> (-5.48%) ⬇️
src/modules/marketplaces/marketplaces.service.ts 81.73% <83.33%> (+<0.01%) ⬆️
src/common/persistence/persistence.service.ts 12.69% <20.00%> (-0.21%) ⬇️
src/modules/s3/s3.service.ts 16.66% <33.33%> (+2.38%) ⬆️
...marketplaces/marketplace-collections.repository.ts 29.41% <16.66%> (-9.05%) ⬇️
...dules/marketplaces/marketplaces-caching.service.ts 24.13% <33.33%> (-1.95%) ⬇️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielailie danielailie merged commit bfab245 into main Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants