Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection stats #1047

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix collection stats #1047

merged 3 commits into from
Oct 23, 2023

Conversation

danielailie
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b127a6e) 42.75% compared to head (8e326ca) 42.74%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1047      +/-   ##
===============================================
- Coverage        42.75%   42.74%   -0.02%     
===============================================
  Files              395      395              
  Lines             8232     8234       +2     
  Branches           949      950       +1     
===============================================
  Hits              3520     3520              
- Misses            3813     3814       +1     
- Partials           899      900       +1     
Flag Coverage Δ
unittests 42.74% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ules/collection-stats/collections-stats.service.ts 84.84% <33.33%> (-5.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gabrielmatei
gabrielmatei previously approved these changes Oct 23, 2023
@@ -105,6 +105,7 @@ export class CacheEventsConsumer {
const profilerMint = new CpuProfiler();
await this.collectionAssets.clearKey(event.id);
await this.collectionAssetsCount.clearKey(event.id);
await this.collectionAssetsCount.clearKey(`${event.id}_undefined`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

andreibancioiu
andreibancioiu previously approved these changes Oct 23, 2023
cfaur09
cfaur09 previously approved these changes Oct 23, 2023
@danielailie danielailie merged commit 606bf50 into development Oct 23, 2023
@danielailie danielailie deleted the FixCachingForCollectionStats branch October 25, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants