Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple saved on whitelist collection #1041

Merged
merged 15 commits into from
Oct 16, 2023

Conversation

danielailie
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (49e51ec) 42.77% compared to head (568a319) 42.76%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1041      +/-   ##
===============================================
- Coverage        42.77%   42.76%   -0.01%     
===============================================
  Files              395      395              
  Lines             8225     8231       +6     
  Branches           947      949       +2     
===============================================
+ Hits              3518     3520       +2     
- Misses            3810     3812       +2     
- Partials           897      899       +2     
Flag Coverage Δ
unittests 42.76% <23.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mmon/services/mx-communication/mx-tools.service.ts 18.00% <ø> (+0.35%) ⬆️
src/common/persistence/persistence.service.ts 12.90% <0.00%> (-0.07%) ⬇️
...marketplaces/marketplace-collections.repository.ts 38.46% <0.00%> (-3.21%) ⬇️
src/modules/marketplaces/marketplaces.service.ts 81.73% <40.00%> (-2.11%) ⬇️
...dules/marketplaces/marketplaces-caching.service.ts 26.08% <16.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gabrielmatei
gabrielmatei previously approved these changes Oct 12, 2023
giurgiur99
giurgiur99 previously approved these changes Oct 12, 2023
@danielailie danielailie dismissed stale reviews from giurgiur99 and gabrielmatei via d8023de October 12, 2023 10:32
gabrielmatei
gabrielmatei previously approved these changes Oct 12, 2023
@danielailie danielailie merged commit acfae38 into development Oct 16, 2023
1 of 3 checks passed
@danielailie danielailie deleted the FixBugOnWhitelistCollection branch October 16, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants