Skip to content

[pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is used #20719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sai6855 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is used #20719

sai6855 wants to merge 2 commits into from
+1 −1

Conversation

@sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 19, 2025 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Dec 19, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20719--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers ▼-1B(0.00%) 🔺+3B(0.00%)
@mui/x-date-pickers-pro ▼-1B(0.00%) 🔺+3B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against e2e2e56

@sai6855 sai6855 added type: bug It doesn't behave as expected. scope: pickers Changes related to the date/time pickers. labels Dec 19, 2025
@sai6855 sai6855 marked this pull request as ready for review December 19, 2025 14:04
Copilot AI review requested due to automatic review settings December 19, 2025 14:04
Copilot AI reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the PickersDay component where styles for days outside the current month were incorrectly applied. The issue was caused by a negation operator (!) that prevented the dayOutsideMonth styles from being applied when isDayOutsideMonth was true.

Key Changes

  • Removed the incorrect negation (!) operator in the overridesResolver function, changing !ownerState.isDayOutsideMonth to ownerState.isDayOutsideMonth

@sai6855 sai6855 changed the title [pickers] Fix Styles applied to MuiPickersDay-dayOutsideMonth [pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is passed Dec 22, 2025
@sai6855 sai6855 changed the title [pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is passed [pickers] Fix Styles applied to PickersDay when MuiPickersDay-dayOutsideMonth is used Dec 22, 2025
@sai6855 sai6855 requested a review from LukasTy December 22, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@LukasTy LukasTy Awaiting requested review from LukasTy

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

scope: pickers Changes related to the date/time pickers. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pickers] Styles applied to MuiPickersDay-dayOutsideMonth actually applied to MuiPickersDay-root

2 participants

@sai6855 @mui-bot