Skip to content

[charts-pro] Heatmap performance improvements #20697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bernardobelchior wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[charts-pro] Heatmap performance improvements #20697

bernardobelchior wants to merge 3 commits into from
+185 −28

Conversation

@bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Dec 17, 2025 •
edited
Loading

Related to #20702.

@bernardobelchior bernardobelchior added performance type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Dec 17, 2025
@mui-bot
Copy link

mui-bot commented Dec 17, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20697--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+885B(+0.20%) 🔺+383B(+0.28%)
@mui/x-charts-premium 🔺+887B(+0.20%) 🔺+337B(+0.25%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 4cc5aa3

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #20697 will improve performances by 23.31%

Comparing bernardobelchior:heatmap-perf-improv (4cc5aa3) with master (f8e6898)1

Summary

⚡ 1 improvement
✅ 13 untouched

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
⚡ Simulation Heatmap: 100x100 grid 9.2 s 7.4 s +23.31%

Footnotes

  1. No successful run was found on master (fc6f598) during the generation of this report, so f8e6898 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 18, 2025
bernardobelchior
bernardobelchior commented Dec 18, 2025
View reviewed changes
packages/x-charts-pro/src/Heatmap/useInteractionItemProps.ts
/**
* Hook to get pointer interaction props for chart items.
*/
export function useInteractionItemProps() {
Copy link
Member Author

@bernardobelchior bernardobelchior Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is pretty much the same as the one for the bar batch renderer PR. After both these PRs are merged we'll have two hooks that basically do the same thing. I'll work on creating a API that makes this extendable to other charts as I suspect we'll want that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bernardobelchior @mui-bot