WIP: new renderers poc #20660
Draft
WIP: new renderers poc #20660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bernardobelchior
commented
Dec 15, 2025
bernardobelchior
commented
- I have followed (at least) the PR section of the contributing guide.
|
Deploy preview: https://deploy-preview-20660--material-ui-x.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #705625 finishes. |
JCQuintas
reviewed
Dec 15, 2025
Comment on lines
+116
to
+124
| ctx.beginPath(); | ||
| ctx.arc( | ||
| (dataPoint.x - drawingArea.left) / scale, | ||
| (dataPoint.y - drawingArea.top) / scale, | ||
| ((isItemFaded ? 1.2 : 1) * series.markerSize) / scale, | ||
| 0, | ||
| 2 * Math.PI, | ||
| ); | ||
| ctx.fill(); |
Member
There was a problem hiding this comment.
Move ctx.beginPath to the top, outside the loop
Move ctx.fill to the bottom, outside the loop
should improve performance
Member
There was a problem hiding this comment.
In general you only have to call fill() for things with different styles, so plot all series 1, then fill, plot all series 2, then fill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.