Skip to content

[charts] Prevent crash and warn user on incorrect axisId when composing #19397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 3, 2025
Merged

[charts] Prevent crash and warn user on incorrect axisId when composing #19397

merged 7 commits into from
Sep 3, 2025

Conversation

JCQuintas
Copy link
Member

Solves #19355

@JCQuintas JCQuintas self-assigned this Sep 1, 2025
@JCQuintas JCQuintas added type: bug It doesn't behave as expected. scope: charts Changes related to the charts. labels Sep 1, 2025
@mui-bot
Copy link

mui-bot commented Sep 1, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19397--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 🔺+48B(+0.01%) 🔺+10B(+0.01%)
@mui/x-charts-pro 🔺+48B(+0.01%) 🔺+10B(+0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 92f9b5b

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 1, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19397 will not alter performance

Comparing JCQuintas:fix-incorrect-axis-id (92f9b5b) with master (a270ad9)

Summary

✅ 10 untouched benchmarks

@JCQuintas JCQuintas merged commit 7681f31 into mui:master Sep 3, 2025
22 checks passed
@JCQuintas JCQuintas deleted the fix-incorrect-axis-id branch September 3, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette alexfauquette is a code owner

@bernardobelchior bernardobelchior Awaiting requested review from bernardobelchior bernardobelchior is a code owner

Assignees

@JCQuintas JCQuintas

Labels
scope: charts Changes related to the charts. type: bug It doesn't behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JCQuintas @mui-bot @prakhargupta1