[code-infra] Detect browser envs that don't support layout#47813
Open
Janpot wants to merge 5 commits intomui:masterfrom
Open
[code-infra] Detect browser envs that don't support layout#47813Janpot wants to merge 5 commits intomui:masterfrom
Janpot wants to merge 5 commits intomui:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Netlify deploy previewhttps://deploy-preview-47813--material-ui.netlify.app/ Bundle size report
|
Janpot
changed the title
Janpot
changed the title
Janpot
force-pushed
the
detect-layout-support
branch
from
bf11b07 to
54bf4ee
Compare
zannager
added
the
scope: code-infra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #47792
Auto-detect test environments that don't support browser layout and alter behavior based on that.
We want to avoid any "TEST ENV" markers for this as users tend to set them up regardless of JSDOM or real browser. This can cause branching into code paths on real browsers that are intended for JSDOM, as we have unknowingly been doing for years as per #47812
Adding back
process.env.NODE_ENV === 'test'to backport to v7 as my change was a breaking one. But to be removed in v9.Questions:
globalThis.FAKE_BROWSERor something in case users override the user agent string of JSDOM? Maybe we wait for demand in v9?