[Autocomplete] fix unintended focus in autocomplete#47808
Open
atharva3333 wants to merge 2 commits intomui:masterfrom
Open
[Autocomplete] fix unintended focus in autocomplete#47808atharva3333 wants to merge 2 commits intomui:masterfrom
atharva3333 wants to merge 2 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-47808--material-ui.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #47661
This issue occurs when the popup of one
Autocompleteoverlaps anotherAutocomplete.Reproduction Steps
Autocompleteto open its popup.Autocomplete.Observed Behavior
During the
mousedownphase (beforemouseup):Autocompleteregains focus.Autocomplete, this causes an unintended label shrink.openOnFocus, the popup opens (since its getting focused) during the mouse hold and select an option on mouse release.This behavior appears to be triggered by the following logic inside
handleMouseDown: