[table cell][theme] Apply alpha before color mixing to border bottom color when nativeColor + cssVariables is used#47762
Open
ZeeshanTamboli wants to merge 3 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-47762--material-ui.netlify.app/ Bundle size report
|
…sVariables-nativeColor
alpha before color mixing to border bottom color when nativeColor + cssVariables is usedalpha before color mixing to border bottom color when nativeColor + cssVariables is used
siriwatknp
reviewed
Feb 16, 2026
| palette.TableCell, | ||
| 'border', | ||
| colorMix(safeLighten, colorMix(safeAlpha, palette.divider, 1), 0.88), | ||
| colorMix(safeLighten, safeAlpha(palette.divider, 1), 0.88), |
Member
There was a problem hiding this comment.
Suggested change
| colorMix(safeLighten, safeAlpha(palette.divider, 1), 0.88), | |
| colorMix(safeLighten, nativeColor ? `oklch(from ${getCssVar('palette-divider')} l c h / 1)` : safeAlpha(palette.divider, 1), 0.88), |
In this case, the closest fix I have is to use relative color to manipulate the alpha channel only.
Member
Author
There was a problem hiding this comment.
It produced the same output from what I proposed. What's the difference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47749
Before: https://stackblitz.com/edit/vitejs-vite-ujmwmxmu?file=src%2FApp.tsx
After: https://stackblitz.com/edit/juadueom?file=src%2FApp.tsx
The colors are slightly different between the colors generated by
color-mix()and the one without it which is expected (docs).