[dialog][modal] Remove disableEscapeKeyDown prop#47695
Merged
silviuaavram merged 8 commits intomui:masterfrom Feb 20, 2026
Merged
[dialog][modal] Remove disableEscapeKeyDown prop#47695silviuaavram merged 8 commits intomui:masterfrom
disableEscapeKeyDown prop#47695silviuaavram merged 8 commits intomui:masterfrom
Conversation
silviuaavram
added
breaking change
Netlify deploy previewBundle size report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the disableEscapeKeyDown prop from Modal, Dialog, and useModal components, aligning with the previous removal of disableBackdropClick. Users should now handle escape key behavior by checking the reason parameter in the onClose callback, providing a more consistent and flexible API design.
Changes:
- Removed
disableEscapeKeyDownprop from Modal, Dialog, and useModal type definitions and implementations - Updated tests to demonstrate the new pattern of handling escape key behavior via the
onClosecallback - Updated API documentation JSON files and examples to remove references to the deprecated prop
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/mui-material/src/Modal/useModal.types.ts | Removed disableEscapeKeyDown prop type definition |
| packages/mui-material/src/Modal/useModal.ts | Removed conditional check for disableEscapeKeyDown, now always calls onClose with escapeKeyDown reason |
| packages/mui-material/src/Modal/Modal.test.js | Updated tests to show how to disable escape key behavior via onClose callback filtering |
| packages/mui-material/src/Modal/Modal.js | Removed disableEscapeKeyDown prop and its PropTypes definition |
| packages/mui-material/src/Modal/Modal.d.ts | Removed disableEscapeKeyDown from TypeScript interface |
| packages/mui-material/src/Dialog/Dialog.test.js | Updated test to filter both backdropClick and escapeKeyDown in the onClose handler |
| packages/mui-material/src/Dialog/Dialog.js | Removed disableEscapeKeyDown prop, its default value, and PropTypes definition |
| packages/mui-material/src/Dialog/Dialog.d.ts | Removed disableEscapeKeyDown from TypeScript interface |
| docs/pages/material-ui/api/modal.json | Removed disableEscapeKeyDown from API documentation |
| docs/pages/material-ui/api/dialog.json | Removed disableEscapeKeyDown from API documentation |
| docs/data/material/components/selects/DialogSelect.tsx | Updated example to filter both backdropClick and escapeKeyDown in handleClose, removed disableEscapeKeyDown prop usage |
| docs/data/material/components/selects/DialogSelect.js | Updated example to filter both backdropClick and escapeKeyDown in handleClose, removed disableEscapeKeyDown prop usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
We should also add this in the upgrade to v9 docs: https://github.com/mui/material-ui/blob/master/docs/data/material/migration/upgrade-to-v9/upgrade-to-v9.md.
siriwatknp
requested changes
Feb 18, 2026
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
Please update this page https://next.mui.com/material-ui/migration/upgrade-to-v9/ to include this breaking change with the migration.
silviuaavram
force-pushed
the
feat/remove-disable-escape-key-down-prop
branch
from
4028856 to
8386e95
Compare
github-actions
bot
added
the
PR: out-of-date
silviuaavram
force-pushed
the
feat/remove-disable-escape-key-down-prop
branch
from
06f5c0a to
b4911ac
Compare
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
reviewed
Feb 19, 2026
ZeeshanTamboli
changed the title
disableEscapeKeyDown prop
siriwatknp
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
disableEscapeKeyDownfromuseModal,ModalandDialog. Change the tests to reflect the change. Change the API docs and relevant examples.Fixes #27306.