-
-
Notifications
You must be signed in to change notification settings - Fork 43
wordwrap should reset and restore ansi at linebreak #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@treilik Not sure you're aware of this, but the test fails in CI. |
|
Thank you @lukasmalkmus, I am aware ;) |
|
Ups, yes. Should have just looked at your changes :) Looking forward to your solution :) |
81e21bd to
fecab68
Compare
|
@lukasmalkmus here you go ;) If you have some thoughts on this, i would love to here them! |
|
Looks good to me, but I'm not that deep into the materia :) Make sure to fix the linter issues which are annotated in the |
|
Didn't noted the linter issues, so i will get to it. Thank you :) |
|
@treilik Whenever you consider this ready for a review, feel free to remove the |
ed15216 to
aca706d
Compare
|
Hey @muesli, if you could spare the time, i would now be happy for a review :) |
|
Hey there - is there any progress here? |
6f6f884 to
7541e7e
Compare
|
Hey muesli! Cheers! |
f68fdaa to
ea699ef
Compare
ansi-sequence should end at linebreak and start again after if there is more text, in the next line.
but hardwrap not working yet
for better managing char-preserving and hardwrap
to test space preserving and HardWrap shortcut function
correcting missspell and adding toplevel-comment period
so that the can be HardWrapped and are not ignored. According Test are added too.
ansi-sequence should end at linebreak and start again after it
if there is more text, in the next line.