fix(p2p): parse maddr correctly #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in case of not specifying a value it would pass a slice of 1 empty element Signed-off-by: Ettore Di Giacinto <[email protected]>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in case of not specifying a value it would pass a slice of 1 empty element
Description
This pull request includes changes to improve the configuration handling in the
newNodeOptsfunction within thecore/p2p/p2p.gofile. The most important change is the modification of how the environment variables forLOCALAI_P2P_LISTEN_MADDRSandLOCALAI_P2P_BOOTSTRAP_PEERS_MADDRSare processed.Improvements to configuration handling:
core/p2p/p2p.go: Modified thenewNodeOptsfunction to handle empty environment variable values more gracefully by checking if the environment variables are non-empty before splitting them into slices.Notes for Reviewers
Signed commits