Add patch to fix building Abseil with CMake 3.30.0 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but Ruby 2.6 is failing for some reason: https://github.com/mudge/re2/actions/runs/9952702253/job/27494586233?pr=159: |
|
The build that is failing is trying to use a system Abseil from Rob Savoury's Build Tools PPA, I'm going to see if I can reproduce it locally in an Ubuntu 20.04 container. |
|
I suspect the problem is that the issue here is the custom libre2-dev deb, let me try building a new one against the latest Abseil. |
|
Fixed by rebuilding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158