Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ondataavailable not firing #18

Open
chrismpalmer opened this issue Jun 24, 2019 · 6 comments
Open

ondataavailable not firing #18

chrismpalmer opened this issue Jun 24, 2019 · 6 comments

Comments

@chrismpalmer
Copy link

I am using webrtc and I haven't been able to successfully mix the peer streams and receive ondataavailable events?

In webrtc, when a new stream is added

if ( audioMixer ) {
audioMixer.appendStreams([event.stream]);
}

Once I do this there are no ondataavailable events. If I only add the local stream I get ondataavailable.

Thanks

@chrismpalmer
Copy link
Author

chrismpalmer commented Jun 24, 2019

I was able to configure MultiStreamMixer correctly. I am getting events firing from the local stream. But when I use MultiStreamMixer,

audioMixer.appendStreams([event.stream]);

Doesn't add the additional audio track. This new track does not show up in the file saved. Only localStream..

Update when I build MultiStreamsMixer with both the peer and the local stream it works.

If I appendStreams after construction it does not add audio,... looking like bug.

Adding stream after recording started , DOES NOT ADD stream to recording.

@muaz-khan
Copy link
Owner

I'll fix it in the next release.

Relevant: muaz-khan/RecordRTC#536

My plans are:

  1. Always createMediaStreamDestination even if there is no audio-track
  2. Use createMediaStreamSource for every new audio-stream. Do not use createMediaStreamDestination again.

muaz-khan added a commit that referenced this issue Jun 24, 2019
@chrismpalmer
Copy link
Author

chrismpalmer commented Jun 24, 2019

Actually I was still including the MultiStreamMixer.js from your website, I removed this references and now RecordRTC is using the patched( from your commit) internal MultiStreamMixer and it does seem to be recording. Thank you for being so attentive.

Do you know if this is possible to do headless on server? Local Stream really isn't too important because the idea is to record all the peer connections.

@BrunoGabrielGodoi
Copy link

I was able to configure MultiStreamMixer correctly. I am getting events firing from the local stream. But when I use MultiStreamMixer,

@chrismpalmer
I'm sorry, how were you able to fire the ondataavalible event of mediaRecorder using the MultiStreamsMixer? I'm having the same issue...

@trackedsupport
Copy link

Actually I was still including the MultiStreamMixer.js from your website, I removed this references and now RecordRTC is using the patched( from your commit) internal MultiStreamMixer and it does seem to be recording. Thank you for being so attentive.

@chrismpalmer Can you explain how you did this?

@lukasfarina
Copy link

hey @muaz-khan , the commit on MultiStreamMixer package works, but wasn't merged with the lib, neither RecordRTC. Is there any prediction of a merge soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants