Conversation
|
Interesting. How would I use it? |
The example shows how to send midi with raw serial packages.. but, I was thinking I'd probably try this: https://docs.rs/embedded-midi/0.1.0/embedded_midi/index.html I could update the example to use that, but I wasn't sure if we'd want to add additional deps. |
|
or.. maybe you're wondering about the hardware? both the field and the patch have MIDI i/o |
|
A bit of both. I've not used MIDI. As far as the extra crate goes that's what [dev-dependencies] exists for. |
| }; | ||
|
|
||
| /// Get a configured serial MIDI device | ||
| pub fn midi( |
There was a problem hiding this comment.
This implementation is very specific with hard coded pins and serial settings. Unless the h/w or protocol restricts it these should be configurable.
There was a problem hiding this comment.
yeah.. this is specific to the serial midi that these 2 devices support, but i could make it more general and then make a specific call if we end up with a Field and or Patch class
There was a problem hiding this comment.
BTW, midi does have a specific serial setting that it needs, but this could be configurable to different pin for non Field or Patch devices.
There was a problem hiding this comment.
As long as it's clear that the specific pins are for field/patch h/w I'm fine with either a specific or general implementation.
There was a problem hiding this comment.
sounds good. i'll make some changes to either make that more clear or make it more general or both
No description provided.