test: avoids test warnings about obvious but intended errors #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
changed the title
|
LGTM! |
grzuy
commented
Jan 24, 2025
| @@ -58,7 +58,7 @@ defmodule HTTP1PlugTest do | |||
| end | |||
|
|
|||
| def unknown_crasher(_conn) do | |||
| 1 / 0 | |||
| 1 + self() | |||
There was a problem hiding this comment.
Heads up, realized that Elixir 1.18 with it's smarter compiler and "type checker" will warn about this also...
There was a problem hiding this comment.
I've fixed this by calling apply(:erlang, :+, [1, self()])
I also updated the other crash site to use this same call, previously it was using 1 = self(). I assume that change is fine? They're both pushed to main in anticipation of a release later today
There was a problem hiding this comment.
I've fixed this by calling
apply(:erlang, :+, [1, self()])
Hehe, cool.
I also updated the other crash site to use this same call, previously it was using
1 = self(). I assume that change is fine?
Yeah, that's fine.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.