Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always close HTTP/1 connection in any case where an error comes out of the plug #452

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Always close HTTP/1 connection in any case where an error comes out of the plug #452

merged 3 commits into from
Jan 8, 2025

Conversation

mtrudel
Copy link
Owner

@mtrudel mtrudel commented Jan 7, 2025 •
edited
Loading

Fixes #451

Previously, Bandit would keep the connection open for errors which it did not log; this was an oversight.

@mtrudel mtrudel mentioned this pull request Jan 7, 2025
Closed
zookzook
zookzook approved these changes Jan 7, 2025
View reviewed changes
Copy link

@zookzook zookzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Fast PR!

@mtrudel mtrudel merged commit 24f2d84 into main Jan 8, 2025
27 checks passed
@mtrudel mtrudel deleted the error_closing branch January 8, 2025 13:53
@mtrudel
Copy link
Owner Author

mtrudel commented Jan 8, 2025

Published as 1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zookzook zookzook zookzook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error handling when receiving invalid JSON within a keepalive connection
2 participants
@mtrudel @zookzook