Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #446

Merged
merged 16 commits into from
Jan 4, 2025
Merged

Improve tests #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5a7f37f
Rename TestHelpers to DateHelpers
mtrudel Jan 3, 2025
e8ee9f2
Refactor ServerHelpers
mtrudel Jan 3, 2025
712c859
Refactor telemetry testing to use messages instead of waiting
mtrudel Jan 3, 2025
6c8a499
Refactor log testing to use messages instead of capture_log
mtrudel Jan 3, 2025
0a4e161
Make tests run sync now that we've made it (mostly) safe
mtrudel Jan 3, 2025
84b838a
Avoid collisions between finch pools for similarly named tests
mtrudel Jan 3, 2025
4767821
Tag off a few intrinsically slow tests to not run locally
mtrudel Jan 3, 2025
f3e4897
Lower default timeout to 100ms
mtrudel Jan 3, 2025
a36ecaa
Increase wait time for log/telemetry messages to 500ms
mtrudel Jan 3, 2025
00ecc2f
Tweak a few explicitly required sleeps
mtrudel Jan 3, 2025
5090914
Fix 'out of process' tests to work around weird Mint behaviour
mtrudel Jan 3, 2025
e797216
Update SimpleH2Client to provide more info about frame types
mtrudel Jan 3, 2025
0d64df1
Improve h2 test that is inherently racy
mtrudel Jan 3, 2025
37e839d
Add sleeps since it seems as if log handler addition is a bit racy
mtrudel Jan 3, 2025
a7d5f7b
Increase Websocket timeouts
mtrudel Jan 3, 2025
1ee81e9
Increase read timeout on TLS warnings test
mtrudel Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/autobahn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
elixir: ${{ fromJSON(inputs.elixirs) }}
otp: ${{ fromJSON(inputs.erlangs) }}
case:
case:
- "1.*,2.*,3.*,4.*,5.*,6.*,7.*,8.*,10.*"
- "9.1.*"
- "9.2.*"
Expand Down Expand Up @@ -69,4 +69,4 @@ jobs:
run: |
mix deps.get
- name: Run Autobahn test
run: mix test --only external_conformance test/bandit/websocket/autobahn_test.exs
run: mix test --only slow test/bandit/websocket/autobahn_test.exs
2 changes: 1 addition & 1 deletion .github/workflows/h2spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ jobs:
run: |
mix deps.get
- name: Run h2spec test
run: mix test --only external_conformance test/bandit/http2/h2spec_test.exs
run: mix test --only slow test/bandit/http2/h2spec_test.exs
2 changes: 1 addition & 1 deletion test/bandit/clock_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defmodule ClockTest do
warnings =
capture_log(fn ->
{"date", date} = Bandit.Clock.date_header()
assert TestHelpers.valid_date_header?(date)
assert DateHelpers.valid_date_header?(date)
end)

assert warnings =~ "Header timestamp couldn't be fetched from ETS cache"
Expand Down
Loading
Loading