Deflate support on chunked responses #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backed this out of main/1.6.0 since there are reports of it breaking. Will re-open and fix |
|
It seems that this PR sends content-encoding headers on the 101 Switching Protocols during websocket upgrades. Details here #422 (comment) |
|
Reopened as #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for deflating chunked responses. Consists of a refactor to first break apart the existing compression routines such that the constituent stages can be called separately throughout the lifecycle of a chunked response, and then using these new routines within chunked responses.
Only deflate is supported on responses