mtgmatcher/mtgjson: Support doublerainbow promo, simplify SLD parsing…

… code
mtgban · Dec 20, 2023 · 4579c63 · 4579c63
1 parent 5efc039
commit 4579c63
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/mtgmatcher/callbacks.go b/mtgmatcher/callbacks.go
@@ -694,16 +694,11 @@ func sldVariant(inCard *Card, card *mtgjson.Card) bool {
 		if inCard.isStepAndCompleat() {
 			result = !result
 		}
-	case "Goblin Lackey",
-		"Goblin Matron",
-		"Goblin Recruiter",
-		"Muxus, Goblin Grandee",
-		"Shattergang Brothers",
-		"Aminatou, the Fateshifter",
-		"Chandra, Flame's Catalyst",
-		"Daretti, Ingenious Iconoclast",
-		"Karn, Scion of Urza",
-		"Venser, the Sojourner":
+	}
+	// All the DoubleRainbow SLD cards not serialized are tagged as two different entries
+	// ie Goblin Lackey or Aminatou, the Fateshifter
+	if hasPrinting(card.Name, "promo_type", mtgjson.PromoTypeDoubleRainbow, "SLD") &&
+		!hasPrinting(card.Name, "promo_type", mtgjson.PromoTypeSerialized, "SLD") {
 		result = strings.HasSuffix(card.Number, mtgjson.SuffixSpecial)
 		if inCard.Foil {
 			result = !result

diff --git a/mtgmatcher/mtgjson/mtgjson.go b/mtgmatcher/mtgjson/mtgjson.go
@@ -188,6 +188,7 @@ const (
 	PromoTypeOilSlick        = "oilslick"
 	PromoTypeConcept         = "concept"
 	PromoTypeConfettiFoil    = "confettifoil"
+	PromoTypeDoubleRainbow   = "doublerainbow"
 
 	PromoTypeThickDisplay  = "thick"
 	PromoTypeJudgeGift     = "judgegift"
@@ -217,6 +218,7 @@ var AllPromoTypes = []string{
 	PromoTypeBuyABox,
 	PromoTypeConcept,
 	PromoTypeConfettiFoil,
+	PromoTypeDoubleRainbow,
 	PromoTypeDracula,
 	PromoTypeDraftWeekend,
 	PromoTypeEmbossed,