[pull] master from sparklemotion:master #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
Hey! Changelogs info seems to be missing or might be in incorrect format. |
- extract helper concat_flags - strip spaces from configuration params
and skip printing the big notice if the library is already build
if, for example, CFLAGS appeared multiple times then it would get clobbered. this change appends all the values to a single set of flags.
This is the default for those libraries, but we were overriding CFLAGS in some cases. Additionally, we need to compile with -U_FORTIFY_SOURCE to avoid Ubuntu's convention of setting -D_FORTIFY_SOURCE=2 when -O2 is set. This leads to problems when running precompiled libraries on musl (see #2100 for details). Closes #2022.
…rintf-and-some-warnings clean up vasprintf and some warnings, and clean up extconf.rb
Nokogiri always have had dependency on Racc, but it was never stated explicitly. This is possible issue for several reasons: 1) There is no way RubyGems/Bundler could avoid loading wrong version of Racc if other package in application specifies different version of Racc then Nokogiri needs. 2) If there is released incompatible Racc 2.x, all old versions of Nokogiri will be broken just because it does not specify its dependencies properly. 3) If Ruby decides to drop Racc from StdLib, all Nokogiri versions will be broken (unnoticeably). Or Ruby will be forced to carry Racc around around although it is possibly obsolete. Fixes #1988
Add explicit Racc depenency.
…ned-by-glibc fix: avoid collision with glibc's canonicalize() method
Fix typo in comment
based on inspection of the pkg_config gem. also: - extract pkg_config gem version requirement - improve the explanatory comment
also remove unnecessary spaces in some CPPFLAGS
to clarify that the presence of the env variable turns the switch on, and the value is ignored
This was set before discovering the encoding problem was with iconv support (see eb69384)
ci: switch to the ruby/setup-ruby action
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -1,21 +1,27 @@ | |||
| <div><img src="https://nokogiri.org/images/nokogiri-serif-black.png" align="right"/></div> | |||
There was a problem hiding this comment.
This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.88.0...v1.7.0) Signed-off-by: dependabot[bot] <[email protected]>
…p-tw-1.7 build(deps-dev): update rubocop requirement from ~> 0.88 to ~> 1.7
to include a question about native gems
to check that we're setting error handlers everywhere we need to. Related to #2168
originally introduced in 771164d but broken in the recent commits. This is an incomplete fix. We should adopt this same strategy of save-and-restore everywhere we set the error handlers.
…failure fix(cruby): SAX and Push parser error handling in the presence of foreign handlers
removing stale entries and grouping
to be clear that --with-foo-lib and --with-foo-include can be passed for any of the libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )