Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rav1e: enable for clangarm64 #14570

Closed
wants to merge 1 commit into from
Closed

rav1e: enable for clangarm64 #14570

wants to merge 1 commit into from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Dec 12, 2022

No description provided.

@Biswa96
Copy link
Member

Biswa96 commented Dec 12, 2022

@jeremyd2019 mentioned something about arm64 & nasm.

@kmilos
Copy link
Contributor Author

kmilos commented Dec 12, 2022 •
edited
Loading

Ah yes, will probably need to exclude that one, thanks.

Seems to build OOTB for aarch64 on Arch though...

Also @MehdiChinoune any reason cargo-c was reverted, any problems?

@MehdiChinoune
Copy link
Collaborator

See #14077

@kmilos
Copy link
Contributor Author

kmilos commented Dec 12, 2022

Thanks, converting to draft until crates are available then. Though the readme gives the impression it should work w/ Clang and aarch64...

@kmilos kmilos marked this pull request as draft December 12, 2022 15:03
@MehdiChinoune
Copy link
Collaborator

cargo-c is now available for clangarm64.

@MehdiChinoune
Copy link
Collaborator

cargo-c refuse to build for aarch64 https://github.com/lu-zero/cargo-c/blob/v0.9.15/src/build.rs#L223
Should we patch it?

@kmilos
Copy link
Contributor Author

kmilos commented Dec 28, 2022 •
edited
Loading

@MehdiChinoune See lu-zero/cargo-c#245 (comment) ;) Upstream seems to be happy to consider any patches we come up with...

@kmilos
Copy link
Contributor Author

kmilos commented Dec 28, 2022

Just rebased for now, but won't be able to merge until cargo-c is patched obviously.

@MehdiChinoune
Copy link
Collaborator

done in #14892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmilos @Biswa96 @MehdiChinoune