Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix typo #37

wants to merge 1 commit into from

Conversation

BMDan
Copy link

@BMDan BMDan commented Jan 6, 2016

fix typo, clarify wording a bit

fix typo, clarify wording a bit
@mstorsjo
Copy link
Owner

mstorsjo commented Jan 6, 2016

While the typo fix in general looks straightforward enough, I'm a bit reluctant to include it.

This isn't an independent project on its own, it's a repackaging of the AAC codec from Android. I include as few differences to the original upstream code as possible, to make sure maintainance of it is manageable - I don't want to diverge functionally from the original. (The differences mainly are in having a different build system, fixing crashes before the fixes get included in the Android version later, fixing other issues that don't matter in the Android context, etc.)

In this case, you could try to get the typos fixed in Android (in the platform/external/aac repo) - in that case the fix will get included here later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants