Imports, workflows, and coverage #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a release workflow, rename test file Signed-off-by: Stephen L Arnold <[email protected]>
Signed-off-by: Stephen L Arnold <[email protected]>
Signed-off-by: Stephen L Arnold <[email protected]>
* should not use fork or /tmp for testing, and tests might actually work on windows Signed-off-by: Stephen L Arnold <[email protected]>
|
I'm not against this, but honestly I had not heard of importlib, and I'm curious about the advantages of using it. |
|
The output from the sdist target is...interesting. How does one get to a proper release version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found this useful for another project but it needed a little cleanup (which I was already doing in several other Python repos) and this is the end result, This uses importlib which is more-or-less future-proof, cleans up tests and test coverage, uses the import bits in the docs build, and throws in a release workflow you might find useful. I did a micro.patch release so we could consume/test it and I left some examples here. Thanks!