Image with single histogram bucket causes invalid VBox->volume #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An image that fits in a single histogram bucket (single color image) causes VBox->volume to be negative due to not setting rgbMax in addition to rgbMax. This leave rgbMax at 0 causing VBox to compute a negative and incorrect volume.
PHP_INT_MIN was introduced in PHP7.
A one color image should result is a VBox where Rmin=Rmax, Gmin=Gmax, Bmin=Bmax, and volume=1 (1*1*1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An image that fits in a single histogram bucket (single color image) causes VBox->volume to be negative due to not setting rgbMax in addition to rgbMax. This leave rgbMax at 0 causing VBox to compute a negative and incorrect volume as
$this->volume = (($this->r2 - $this->r1 + 1) * ($this->g2 - $this->g1 + 1) * ($this->b2 - $this->b1 + 1));.