Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUBackend: Add support for setStencilReference(). #30470

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 6, 2025

Fixed #30469.

Description

The PR makes sure WebGPUBackend uses the stencilRef value of the current material to call setStencilReference().

Copy link

github-actions bot commented Feb 6, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.12
78.22
336.12
78.22
+0 B
+0 B
WebGPU 516.99
143.53
517.07
143.55
+84 B
+18 B
WebGPU Nodes 516.45
143.43
516.54
143.44
+84 B
+16 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.17
112.09
465.17
112.09
+0 B
+0 B
WebGPU 588.99
159.73
589.07
159.75
+84 B
+17 B
WebGPU Nodes 544.35
149.29
544.44
149.3
+84 B
+16 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 6, 2025
@Mugen87 Mugen87 merged commit f883c99 into mrdoob:dev Feb 6, 2025
10 of 11 checks passed
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 6, 2025

It seems CodeQL is broken at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPUBackend lacks support for setting the material stencil value
1 participant