Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector4: Add divide(). #29759

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Vector4: Add divide(). #29759

merged 1 commit into from
Oct 29, 2024

Conversation

kristiker
Copy link
Contributor

@kristiker kristiker commented Oct 28, 2024

Fixed #29751

Description

Adds the divide method to Vector4 class.

Copy link

github-actions bot commented Oct 28, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 691.6
171.42
691.67
171.43
+70 B
+9 B
WebGPU 818.94
220.87
819.01
220.88
+70 B
+16 B
WebGPU Nodes 818.45
220.73
818.52
220.73
+70 B
-5 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.75
112.17
463.82
112.17
+70 B
+6 B
WebGPU 539.8
145.81
539.87
145.81
+70 B
+7 B
WebGPU Nodes 495.8
135.63
495.87
135.63
+70 B
+6 B

@Mugen87 Mugen87 added this to the r170 milestone Oct 29, 2024
@Mugen87 Mugen87 changed the title Add Vector4.divide, to match Vector3 and Vector2 function set Vector4: Add divide(). Oct 29, 2024
@Mugen87 Mugen87 merged commit bbfdeac into mrdoob:dev Oct 29, 2024
12 checks passed
@kristiker kristiker deleted the vector4_divide branch October 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector4 missing divide method
2 participants