WebGLRenderer: add reverse-z via EXT_clip_control #29445
+104
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Comment on lines
+2034
to
+2047
| if ( capabilities.reverseDepthBuffer ) { | ||
|
|
||
| toReversedProjectionMatrix( camera.projectionMatrix ); | ||
|
|
||
| } | ||
|
|
||
| p_uniforms.setValue( _gl, 'projectionMatrix', camera.projectionMatrix ); | ||
|
|
||
| if ( capabilities.reverseDepthBuffer ) { | ||
|
|
||
| toForwardProjectionMatrix( camera.projectionMatrix ); | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Can I call uniformMatrix4f here somehow? Should be fast and clean.
There was a problem hiding this comment.
Do you mind explaining in more detail what you want to do?
Mugen87
reviewed
Sep 19, 2024
| @@ -57,6 +57,58 @@ import { WebGLUniformsGroups } from './webgl/WebGLUniformsGroups.js'; | |||
| import { createCanvasElement, probeAsync, warnOnce } from '../utils.js'; | |||
| import { ColorManagement } from '../math/ColorManagement.js'; | |||
|
|
|||
| function toReversedProjectionMatrix( projectionMatrix ) { | |||
There was a problem hiding this comment.
Can we put these functions into src/utils.js?
Mugen87
reviewed
Sep 19, 2024
|
|
||
| if ( capabilities.reverseDepthBuffer ) { | ||
|
|
||
| toForwardProjectionMatrix( camera.projectionMatrix ); |
There was a problem hiding this comment.
Instead of recomputing the projection matrix, couldn't you store the previous projection matrix in a temporary variable and then copy it back? Something like:
camera.projectionMatrix.copy( currentProjectionMatrix );
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22017 (comment)
Description
Implements a reversed depth buffer with a [0, 1] projection matrix via
EXT_clip_control, which is a strict improvement over logarithmic depth where supported. A reverse depth buffer exploits the high precision range of [0, ~0.8] and inverts depth to better the distribution at distance. This is not only significantly faster than logarithmic depth (where use ofgl_FragDepthdisables early-z optimizations and MSAA coverage) but more accurate. See the below articles, which visualize this effect.https://tomhultonharrop.com/mathematics/graphics/2023/08/06/reverse-z.html
https://developer.nvidia.com/blog/visualizing-depth-precision
As both a [0, 1] and reversed projection matrix would require drastic changes to sensitive code like frustum planes or raycasting, I've hidden both conversions when setting the
projectionMatrixuniform inWebGLRenderer. It's possible this can be moved to a shader chunk, but any inline clip-space math must account for this mode, and we'll need to add a shader define accordingly.The same is true for logarithmic depth, e.g., pmndrs/drei#1737. I've debated adding methods to packing chunks for these.