Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: WebGL fallback, use shared UBOs for common uniform groups #29420

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29386

WebGL examples broken by lack of shared buffers now work.

Copy link

github-actions bot commented Sep 16, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 686.07
169.79
686.07
169.79
+0 B
+0 B
WebGPU 832.49
223.05
832.51
223.04
+16 B
-4 B
WebGPU Nodes 832
222.92
832.02
222.92
+16 B
-4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53
462.42
111.53
+0 B
+0 B
WebGPU 529.96
142.77
529.98
142.77
+16 B
-4 B
WebGPU Nodes 486.62
132.63
486.64
132.63
+16 B
-2 B

@Mugen87 Mugen87 added this to the r169 milestone Sep 16, 2024
@sunag
Copy link
Collaborator

sunag commented Sep 16, 2024

Great revision, thanks! This should also have a positive impact on performance.

/cc @RenaudRohlinger #29386 (comment)

@sunag sunag merged commit 6261140 into mrdoob:dev Sep 16, 2024
12 checks passed
@aardgoose aardgoose deleted the webgl-un branch September 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants