SpriteNodeMaterial: Add sizeAttenuation #29394
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
RenaudRohlinger
changed the title
|
Could someone test the example |
RenaudRohlinger
changed the title
|
Can you please test with a single sprite and confirm disabling size attenuation works as you expect it to? I tried to help, but the PR is not working for me in its current form. |
|
The issue seems to be fixed and was related to using
|
| @@ -317,6 +317,12 @@ export default class RenderObject { | |||
|
|
|||
| } | |||
|
|
|||
| if ( object.center ) { | |||
|
|
|||
| cacheKey += object.center.x + ',' + object.center.y + ','; | |||
There was a problem hiding this comment.
uniform values should not generate cache key.
There was a problem hiding this comment.
Unfortunately center is not a uniform value.
In that case we probably want to deprecate that property and move it to the SpriteNodeMaterial as SpriteNodeMaterial.centerNode?
There was a problem hiding this comment.
It seems to be uniform in both renderers, but I think you may have a problem related to the uniform reference. Maybe if you replace uniform() with reference( 'center', 'vec2' ) can it work in your tests?
| setupPosition( { object, context } ) { | ||
| setupPosition( { object, camera, context } ) { | ||
|
|
||
| const useSizeAttenuation = this.sizeAttenuation; |
There was a problem hiding this comment.
const sizeAttenuation = this.sizeAttenuation;
Related issue: #29269 #29374
Description
Following #29374, I will spread the features and fixes among multiple PRs instead. This fixes #29269.
This contribution is funded by Segments.AI & Utsubo