[pull] dev from ArchiveBox:dev #1
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
archivebox/main.py
Outdated
| 'youtube_dl', | ||
| ], capture_output=True, text=True, cwd=out_dir).stdout.split('Location: ')[-1].split('\n', 1)[0] | ||
| NEW_YOUTUBEDL_BINARY = Path(pkg_path) / 'youtube_dl' / '__main__.py' | ||
| os.chmod(NEW_YOUTUBEDL_BINARY, 0o777) |
Check failure
Code scanning / CodeQL
Overly permissive file permissions
| if PUBLIC_INDEX: | ||
| return redirect('/public') | ||
|
|
||
| return redirect(f'/admin/login/?next={request.path}') |
Check warning
Code scanning / CodeQL
URL redirection from remote source
|
|
||
| def get(self, request, path): | ||
| if not request.user.is_authenticated and not PUBLIC_SNAPSHOTS: | ||
| return redirect(f'/admin/login/?next={request.path}') |
Check warning
Code scanning / CodeQL
URL redirection from remote source
|
|
||
| # missing trailing slash -> redirect to index | ||
| if '/' not in path: | ||
| return redirect(f'{path}/index.html') |
Check warning
Code scanning / CodeQL
URL redirection from remote source
| response = super().get(*args, **kwargs) | ||
| return response | ||
| else: | ||
| return redirect(f'/admin/login/?next={self.request.path}') |
Check warning
Code scanning / CodeQL
URL redirection from remote source
archivebox/core/admin.py
Outdated
|
|
||
| def add_view(self, request): | ||
| if not request.user.is_authenticated: | ||
| return redirect(f'/admin/login/?next={request.path}') |
Check warning
Code scanning / CodeQL
URL redirection from remote source
Fixes: attributeerror: 'list' object has no attribute 'SOURCES_DIR'
I was getting: ImportError: cannot import name 'CONSTANTS' from partially initialized module 'archivebox' (most likely due to a circular import) (/nix/store/6fy0wgy7r3ld3k590kxgxrc0r1cca347-archivebox-0.8.6rc3/lib/python3.12/site-packages/archivebox/__init__.py)
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )