fix(gcc): compatibility with GCC14 #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 14 made passing an "incompatible" pointer type to another function an error.
The issue comes from builtin add-carry and sub-borrow.
Nim
uint64
maps toNU64
which itself maps touint64_t
which itself maps tolong unsigned int
on x86-64.However
_addcarry_u64
has for signatureunsigned char _addcarry_u64 (unsigned char c_in, unsigned __int64 a, unsigned __int64 b, unsigned __int64 * out)
unsigned __int64
maps tounsigned long long
which is deemed incompatible withuint64_t
so we need an explicit cast.