Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFT + Trusted setup fixes #254

Merged
merged 2 commits into from
Aug 27, 2023
Merged

FFT + Trusted setup fixes #254

merged 2 commits into from
Aug 27, 2023

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Aug 14, 2023

  • FFT fixes
  • Trusted setup fixes

Checking the trusted setup serialization following the FFT fixes shows that we are differing from spec:

vimdiff -y <(xxd constantine/trusted_setups/trusted_setup_ethereum_kzg_test_minimal_old.tsif) <(xxd constantine/trusted_setups/trusted_setup_ethereum_kzg_test_minimal.tsif)

image

The 32 bytes slot for ethereum_deneb_kzg + padding has disappeared during refactoring of the #239 PR

@mratsim mratsim marked this pull request as ready for review August 27, 2023 13:27
@mratsim mratsim merged commit 8b43b55 into master Aug 27, 2023
12 checks passed
@mratsim mratsim deleted the fft-fixes branch August 28, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant