refactor to strategy classes

src/Mpociot/Versionable/Encoders/Encoder.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Mpociot\Versionable\Encoders;
+
+interface Encoder
+{
+    /**
+     * @param mixed $data
+     */
+    public function encode($data): string;
+
+    /**
+     * @return mixed
+     */
+    public function decode(string $data);
+}

src/Mpociot/Versionable/Encoders/JsonEncoder.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Mpociot\Versionable\Encoders;
+
+class JsonEncoder implements Encoder
+{
+    public function encode($data): string
+    {
+        return json_encode($data);
+    }
+
+    public function decode(string $data)
+    {
+        return json_decode($data, true);
+    }
+}

src/Mpociot/Versionable/Encoders/SerializeEncoder.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Mpociot\Versionable\Encoders;
+
+class SerializeEncoder implements Encoder
+{
+    public function encode($data): string
+    {
+        return serialize($data);
+    }
+
+    public function decode(string $data)
+    {
+        return unserialize($data);
+    }
+}

src/Mpociot/Versionable/Version.php

@@ -4,6 +4,8 @@
 use Illuminate\Support\Facades\Config;
 use Illuminate\Database\Eloquent\Model as Eloquent;
 use Illuminate\Database\Eloquent\Model;
+use Mpociot\Versionable\Encoders\Encoder;
+use Mpociot\Versionable\Encoders\SerializeEncoder;
 
 /**
  * Class Version
@@ -32,12 +34,13 @@ public function versionable()
     }
 
     /**
-     * Return the encoding
-     * @return mixed
+     * Get the encoder.
+     *
+     * @return Encoder
      */
-    private function getEncoding()
+    private function getEncoder(): Encoder
     {
-        return config('versionable.encoding', 'serialize');
+        return app(config('versionable.encoder', SerializeEncoder::class));
     }
 
     /**
@@ -59,12 +62,12 @@ public function getModel()
         $modelData = is_resource($this->model_data)
             ? stream_get_contents($this->model_data,-1,0)
             : $this->model_data;
-        $modelDataEncoded = $this->getEncoding() === 'json' ? json_decode($modelData, true) : unserialize($modelData);
+        $modelDataDecoded = $this->getEncoder()->decode($modelData);
 
         $className = self::getActualClassNameForMorph($this->versionable_type);
         $model = new $className();
         $model->unguard();
-        $model->fill($modelDataEncoded);
+        $model->fill($modelDataDecoded);
         $model->exists = true;
         $model->reguard();
         return $model;

src/Mpociot/Versionable/VersionableTrait.php

@@ -3,6 +3,8 @@
 
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Database\Eloquent\Relations\MorphMany;
+use Mpociot\Versionable\Encoders\Encoder;
+use Mpociot\Versionable\Encoders\SerializeEncoder;
 
 /**
  * Class VersionableTrait
@@ -29,13 +31,13 @@ protected function getVersionClass()
     }
 
     /**
-     * Get the encoding, the default is serialize.
+     * Get the encoder.
      *
-     * @return string
+     * @return Encoder
      */
-    protected function getEncoding()
+    protected function getEncoder(): Encoder
     {
-        return config('versionable.encoding', 'serialize');
+        return app(config('versionable.encoder', SerializeEncoder::class));
     }
 
     /**
@@ -186,9 +188,7 @@ protected function versionablePostSave()
 
             $versionedHiddenFields = $this->versionedHiddenFields ?? [];
             $this->makeVisible($versionedHiddenFields);
-            $version->model_data = $this->getEncoding() === 'json'
-                ? json_encode($this->attributesToArray())
-                : serialize($this->attributesToArray());
+            $version->model_data = $this->getEncoder()->encode($this->attributesToArray());
             $this->makeHidden($versionedHiddenFields);
 
             if (!empty( $this->reason )) {

src/config/config.php

@@ -11,7 +11,7 @@
 
     /*
      * The encoding to use for the model data encoding.
-     * Default is 'serialize' and uses PHP serialize() but 'json' is also supported
      */
-    'encoding' => 'serialize',
+    'encoder' => \Mpociot\Versionable\Encoders\SerializeEncoder::class,
+
 ];

tests/VersionableTest.php

@@ -532,7 +532,7 @@ public function testWhereModelHasMorphMap()
 
     public function testVersionWithJson()
     {
-        $this->app['config']->set('versionable.encoding', 'json');
+        $this->app['config']->set('versionable.encoder', \Mpociot\Versionable\Encoders\JsonEncoder::class);
 
         $user = new TestVersionableUser();
         $user->name = "Marcel";